{AzureContainerApp} fixes Azure/azure-cli-extensions#5781 fix for 'NoneType' object does not support item assignment#5791
Closed
navba-MSFT wants to merge 6 commits intoAzure:mainfrom
Closed
{AzureContainerApp} fixes Azure/azure-cli-extensions#5781 fix for 'NoneType' object does not support item assignment#5791navba-MSFT wants to merge 6 commits intoAzure:mainfrom
navba-MSFT wants to merge 6 commits intoAzure:mainfrom
Conversation
…ot support item assignment fix for TypeError: 'NoneType' object does not support item assignment while running the `az containerapp dapr enable` command
ghost
requested a review
from 
ghost
added
the
Collaborator
|
AzureContainerApp |
vinisoto
approved these changes
Jan 21, 2023
Contributor
|
Hi, I've submitted as PR for this problem here: #5782 |
StrawnSC
suggested changes
Jan 23, 2023
Contributor
StrawnSC
left a comment
StrawnSC
left a comment
There was a problem hiding this comment.
I still get an error when I try to use this code for enabling dapr:
We should add safe_gets in lines 2371 and 2374 with a default=[] so that we don't get "None type is not iterable" errors
Contributor
|
could you try to add test for the none type scenario in https://github.com/Azure/azure-cli-extensions/blob/main/src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py#L583 |
Contributor
|
@navba-MSFT Could you please resolve these CI issues? |
PramodValavala-MSFT
added
the
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5781
fix for TypeError: 'NoneType' object does not support item assignment while running the
az containerapp dapr enablecommandThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.